module::network: Ability to change speed unit text (B/s) #2068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2068 +/- ##
=========================================
- Coverage 6.92% 6.92% -0.01%
=========================================
Files 153 153
Lines 10482 10483 +1
=========================================
Hits 726 726
- Misses 9756 9757 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Would it make sense to rename the setting to |
604897b to
8e52cdc
Compare
|
The I also fixed the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like having
B/sat the end of the speed value is generally not necessary and takes too much space.This pull request adds a
udspeed-unitvariable to be able to display the unit text in other formats. By default the value isB/sto keep the old behaviour. The K/M/G suffixes are still hardcoded and are displayed just before the unit.Note: this is a "text-only" feature, setting
speed-unit = "b/swon't change the output value from bytes per second to bits per second.Examples:
speed-unit = ""will display speeds like:12842K64Gspeed-unit = "Bytes/sec"will display speeds like:128 Bytes/sec42KBytes/sec64GBytes/sec