fix(build): Use CMAKE_INSTALL_FULL_<dir> for default config #2917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eac0d0e to
198036a
Compare
Using CMAKE_INSTALL_SYSCONFDIR does respect CMAKE_INSTALL_PREFIX, but it prefixes it to CMAKE_INSTALL_SYSCONFDIR, which results in the default config being installed to /usr/etc/polybar/config.ini or /usr/local/etc/polybar/config.ini CMAKE_INSTALL_FULL_SYSCONFDIR gives an absolute path that respects the prefix but does the right thing (uses /etc) if it is /usr Ref: polybar#2770
198036a to
4e1fc5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Using CMAKE_INSTALL_SYSCONFDIR does respect CMAKE_INSTALL_PREFIX, but it
prefixes it to CMAKE_INSTALL_SYSCONFDIR, which results in the default
config being installed to /usr/etc/polybar/config.ini or
/usr/local/etc/polybar/config.ini
CMAKE_INSTALL_FULL_SYSCONFDIR gives an absolute path that respects the
prefix but does the right thing (uses /etc) if it is /usr
Also makes
/usrthe default installation prefix because the cmake special case does not exist for/usr/localRelated Issues & Documents
Ref: #2770
Documentation (check all applicable)
The compiling page mentions polybar will be installed to
/usr/local/bin, this needs to be changed to/usr/bin