Skip to content

Conversation

patrick96
Copy link
Member

@patrick96 patrick96 commented Oct 23, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Build

Description

Now requires gcc8 or clang7

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

Update to mention new required compiler versions (gcc8 or clang7) and package names

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #2847 (49c1a90) into master (291a484) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2847   +/-   ##
=======================================
  Coverage   13.17%   13.17%           
=======================================
  Files         162      162           
  Lines       11509    11509           
=======================================
  Hits         1516     1516           
  Misses       9993     9993           
Flag Coverage Δ
unittests 13.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/string.cpp 94.92% <100.00%> (ø)
src/modules/meta/factory.cpp 0.00% <0.00%> (ø)
include/modules/meta/base.inl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@patrick96 patrick96 added this to the 3.7.0 milestone Oct 23, 2022
Now requires gcc8 or clang7
@patrick96 patrick96 merged commit 10cdec3 into polybar:master Oct 23, 2022
@patrick96 patrick96 deleted the cpp17 branch October 23, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant