Skip to content

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

The issue has been fixed in the linux kernel version 5.9 and above so we are removing our workaround for this from polybar. Users with older versions can still work around this by explicitly setting use-actual-brightness to false, it is just not done by default anymore.

Related Issues & Documents

Closes #2835
Ref https://bugzilla.kernel.org/show_bug.cgi?id=203905
Ref torvalds/linux@69d9f42

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

Remove note for default value of use-actual-brightness

@patrick96 patrick96 added this to the 3.7.0 milestone Oct 8, 2022
The issue has been fixed in the linux kernel version 5.9 and above so we
are removing our workaround for this from polybar.
Users with older versions can still work around this by explicitly
setting `use-actual-brightness` to false, it is just not done by default
anymore.

Closes polybar#2835
Ref https://bugzilla.kernel.org/show_bug.cgi?id=203905
Ref torvalds/linux@69d9f42
@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Merging #2839 (6f016b8) into master (1d4e30c) will increase coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2839      +/-   ##
==========================================
+ Coverage   13.42%   13.48%   +0.06%     
==========================================
  Files         151      151              
  Lines       11482    11505      +23     
==========================================
+ Hits         1541     1552      +11     
- Misses       9941     9953      +12     
Flag Coverage Δ
unittests 13.48% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/backlight.cpp 0.00% <0.00%> (ø)
src/x11/icccm.cpp 0.00% <0.00%> (ø)
src/modules/xwindow.cpp 0.00% <0.00%> (ø)
src/drawtypes/iconset.cpp 81.81% <0.00%> (+38.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@patrick96 patrick96 merged commit e971318 into polybar:master Oct 8, 2022
@patrick96 patrick96 deleted the backlight-amdgpu branch October 8, 2022 13:52
@patrick96 patrick96 mentioned this pull request Nov 5, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Brightness not updated with amdgpu_bl
1 participant