Skip to content

Conversation

VanillaViking
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

xwindow module does not crash when a tag is not provided in format.

Related Issues & Documents

Fixes #2826

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #2833 (489b025) into master (5719d13) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2833      +/-   ##
==========================================
- Coverage   13.40%   13.40%   -0.01%     
==========================================
  Files         151      151              
  Lines       11499    11500       +1     
==========================================
  Hits         1541     1541              
- Misses       9958     9959       +1     
Flag Coverage Δ
unittests 13.40% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/xwindow.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@patrick96 patrick96 merged commit 03987b1 into polybar:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: xwindow module crashes entire bar if format doesn't contain tag
2 participants