added: better fuzzy matching #2831
Conversation
Improved fuzzy matching so that it finds the longest matching icon instead of the first possible match
|
please let me know if I've forgotten anything, this is my first PR 😄 |
|
just removed the debug output, should fix the workflow check fails |
Codecov Report
@@ Coverage Diff @@
## master #2831 +/- ##
==========================================
+ Coverage 13.40% 13.48% +0.08%
==========================================
Files 151 151
Lines 11499 11506 +7
==========================================
+ Hits 1541 1552 +11
+ Misses 9958 9954 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
- added return statements to the fuzzy finder - added tests to check whether the fuzzy finder works.
There was a problem hiding this comment.
Only some minor style changes. Please also run clang-format on the files you changed. https://polybar.readthedocs.io/en/latest/dev/style-guide.html
|
there is still a pending requested change, but don't worry as I've just implemented those changes myself and the conversation was made outdated. All the relevant changes have been applied. I'm trying to submit this pull request for hacktoberfest so it is my first time for a bigger project! |
There is no need to apologize, review cycles are part of the process ;) Thank you for contributing to polybar! |
|
Congrats on your first PR in polybar 🚀 |
Improved fuzzy matching so that it finds the longest matching icon instead of the first possible match
What type of PR is this? (check all applicable)
Description
This improves the
fuzzy-matchoption in a few modules, such as the i3 module. Instead of matching the first applicable substring, the option will now search through and find the longest matching substring.Related Issues & Documents
Closes #2829
Fixes #2095 (similar issue)
Documentation (check all applicable)