Skip to content

Conversation

patrick96
Copy link
Member

@patrick96 patrick96 commented Oct 2, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

The xwindow module can now show the contents of the WM_CLASS property of the active window. %instance% shows the first value and %class% shows the second.

Some examples of what applications actually show:

Application %instance% %class%
Firefox Navigator firefox
Thunderbird Mail thunderbird
Steam Steam Steam
Spotify spotify Spotify
rxvt-unicode urxvt URxvt
xterm xterm XTerm
Alacritty Alacritty Alacritty
Vlc vlc vlc

Related Issues & Documents

ICCCM Spec: https://x.org/releases/X11R7.6/doc/xorg-docs/specs/ICCCM/icccm.html#wm_class_property

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

The new tokens need to be added to the xwindow page. Also describe what they actually do.

@patrick96 patrick96 added this to the 3.7.0 milestone Oct 2, 2022
@patrick96 patrick96 force-pushed the feat/xwindow-wm-class branch from c4fe44c to 6a85bc4 Compare October 2, 2022 10:20
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Merging #2830 (d01c0f1) into master (c443365) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
- Coverage   13.42%   13.40%   -0.03%     
==========================================
  Files         151      151              
  Lines       11480    11499      +19     
==========================================
  Hits         1541     1541              
- Misses       9939     9958      +19     
Flag Coverage Δ
unittests 13.40% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/xwindow.cpp 0.00% <0.00%> (ø)
src/x11/icccm.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tboerger
Copy link

tboerger commented Oct 2, 2022

Nice, exactly what I wanted to have 😂

@patrick96 patrick96 force-pushed the feat/xwindow-wm-class branch from 6a85bc4 to d01c0f1 Compare October 2, 2022 15:07
@patrick96 patrick96 merged commit 5719d13 into master Oct 2, 2022
@patrick96 patrick96 deleted the feat/xwindow-wm-class branch October 2, 2022 18:57
@patrick96 patrick96 mentioned this pull request Nov 5, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants