Skip to content

Also monitor include-files for changes when --reload is set #2759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2022
Merged

Also monitor include-files for changes when --reload is set #2759

merged 3 commits into from
Jul 9, 2022

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Jul 2, 2022

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

I fixed this issue by creating event handlers for every include-file present in m_included. I also added a method get_included_files in the controller class to make this possible.

Related Issues & Documents

Fixes #675

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

patrick96
patrick96 approved these changes Jul 9, 2022
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

I also did some cleanup

@codecov
Copy link

codecov bot commented Jul 9, 2022

Codecov Report

Merging #2759 (0173a88) into master (a42e533) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   13.53%   13.52%   -0.02%     
==========================================
  Files         152      152              
  Lines       11387    11396       +9     
==========================================
  Hits         1541     1541              
- Misses       9846     9855       +9
Flag Coverage Δ
unittests 13.52% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/components/config.hpp 0.00% <0.00%> (ø)
include/components/controller.hpp 0.00% <ø> (ø)
src/components/config.cpp 0.00% <0.00%> (ø)
src/components/controller.cpp 0.00% <0.00%> (ø)
src/ipc/util.cpp 73.07% <0.00%> (ø)
src/x11/tray_manager.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42e533...0173a88. Read the comment docs.

@patrick96 patrick96 merged commit 98d584c into polybar:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--reload doesn't monitor include-files
2 participants
@zjeffer @patrick96