fix(pulse): Hanging during connection setup #2709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If context_state_callback is called before we call pa_threaded_mainloop_wait in the main thread, the signal is lost and we wait forever. Fixes polybar#2707 Ref polybar#2699 Ref polybar#2697
Codecov Report
@@ Coverage Diff @@
## hotfix/3.6.3 #2709 +/- ##
================================================
- Coverage 13.76% 13.76% -0.01%
================================================
Files 153 153
Lines 11296 11299 +3
================================================
Hits 1555 1555
- Misses 9741 9744 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
If context_state_callback is called before we call
pa_threaded_mainloop_wait in the main thread, the signal is lost and we
wait forever.
Fixes #2707
Ref #2699
Ref #2697
Documentation (check all applicable)