Skip to content

filesystem: Use fallback if no mountpoints are specified #2705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

filesystem: Use fallback if no mountpoints are specified #2705

merged 1 commit into from
May 2, 2022

Conversation

Zaphoood
Copy link
Contributor

@Zaphoood Zaphoood commented May 1, 2022

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other

Description

When no mountpoints are specified for an internal/fs module, use / as a fallback and display a warning.

Related Issues & Documents

Impelements a part of #2572

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

In 'Module: filesystem', in the section 'Basic settings', the lines

; Mountpoints to display
mount-0 = /
mount-1 = /home
mount-2 = /var

should be changed to

; Mountpoints to display
; Default: /
mount-0 = /
mount-1 = /home
mount-2 = /var

@codecov
Copy link

codecov bot commented May 1, 2022 •
edited
Loading

Codecov Report

Merging #2705 (9b73630) into master (f9fc02e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   13.58%   13.58%   -0.01%     
==========================================
  Files         152      152              
  Lines       11337    11340       +3     
==========================================
  Hits         1540     1540              
- Misses       9797     9800       +3
Flag Coverage Δ
unittests 13.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/fs.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fc02e...9b73630. Read the comment docs.

patrick96
patrick96 requested changes May 1, 2022
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicks

patrick96
patrick96 approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@patrick96 patrick96 merged commit 423cc17 into polybar:master May 2, 2022
@patrick96 patrick96 mentioned this pull request May 2, 2022
Open
@Zaphoood Zaphoood deleted the fs-fallback branch May 2, 2022 11:05
@patrick96 patrick96 mentioned this pull request Nov 5, 2023
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zaphoood @patrick96