Skip to content

Conversation

marxlaml
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Adds the scroll-interval option to internal/backlight, which allows the user to set the scrolling interval when changing the backlight module.

Related Issues & Documents

Closes #2696

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

New config option should be described in Wiki.

@marxlaml marxlaml marked this pull request as ready for review April 27, 2022 06:35
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #2700 (e0feae6) into master (b529279) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2700      +/-   ##
==========================================
- Coverage   13.58%   13.58%   -0.01%     
==========================================
  Files         152      152              
  Lines       11336    11337       +1     
==========================================
  Hits         1540     1540              
- Misses       9796     9797       +1     
Flag Coverage Δ
unittests 13.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/backlight.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b529279...e0feae6. Read the comment docs.

@patrick96 patrick96 merged commit 6a2d7b5 into polybar:master Apr 27, 2022
@patrick96 patrick96 mentioned this pull request Nov 5, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backlight scrolling should have an interval option
2 participants