fix: check if double click action associated #2695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2695 +/- ##
=======================================
Coverage 13.58% 13.58%
=======================================
Files 152 152
Lines 11339 11336 -3
=======================================
Hits 1540 1540
+ Misses 9799 9796 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
patrick96
requested changes
Apr 22, 2022
When a module is clicked, only wait for the double click interval if a double click action is associated with that module. Otherwise trigger the click right away. Fixes: polybar#2663
Zaphoood
commented
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When a module is clicked, only wait for the double click interval if a double click action is associated with that module. Otherwise trigger the click right away.
The check is button specific, so if the user performs a right click on an area that has an action for a double left click, the right click is triggered immediately.
Related Issues & Documents
Fixes: #2663
Documentation (check all applicable)