Skip to content

fix(battery): polling-interval not working #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

fix(battery): polling-interval not working #2677

merged 1 commit into from
Apr 7, 2022

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Related Issues & Documents

Fixes #2649

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 added this to the 3.6.3 milestone Apr 4, 2022
@patrick96 patrick96 mentioned this pull request Apr 4, 2022
Closed
5 tasks
@patrick96 patrick96 changed the base branch from master to hotfix/3.6.3 April 4, 2022 16:39
@patrick96 patrick96 force-pushed the 2649-battery-poll-fallback branch from 90e9a3f to 5f3037d Compare April 4, 2022 16:39
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #2677 (5f3037d) into hotfix/3.6.3 (9b28ba7) will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           hotfix/3.6.3    #2677   +/-   ##
=============================================
  Coverage         13.77%   13.77%           
=============================================
  Files               153      153           
  Lines             11284    11284           
=============================================
  Hits               1554     1554           
  Misses             9730     9730
Flag Coverage Δ
unittests 13.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/battery.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b28ba7...5f3037d. Read the comment docs.

@patrick96 patrick96 merged commit 7d9227c into polybar:hotfix/3.6.3 Apr 7, 2022
@patrick96 patrick96 deleted the 2649-battery-poll-fallback branch April 7, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.3
Development

Successfully merging this pull request may close these issues.

[Bug]: Battery module doesn't update unless I reload
1 participant
@patrick96