Skip to content

feat(text): Add standard format with label #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2022
Merged

feat(text): Add standard format with label #2676

merged 1 commit into from
Apr 4, 2022

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Makes the text module use the standard format+label as all other modules in a non-breaking way.

The content key is deprecated in favor of format which has the exact same functionality, except that it also supports the <label> tag.

Related Issues & Documents

Closes #1331
Closes #1342
Fixes #2673

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

The example under "Additional Formatting" in the wiki should be:

; @deprecated Use format and/or label to define the module text
; content = Some random label

; Available tags:
;   <label> (default)
format = <label>
format-background = #000
format-foreground = #fff
format-padding = 4

; No tokens available
label = Some random label

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #2676 (28fbc0f) into master (652652f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2676      +/-   ##
==========================================
- Coverage   13.63%   13.62%   -0.02%     
==========================================
  Files         149      149              
  Lines       11276    11286      +10     
==========================================
  Hits         1538     1538              
- Misses       9738     9748      +10
Flag Coverage Δ
unittests 13.62% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/modules/text.hpp 0.00% <ø> (ø)
src/modules/text.cpp 0.00% <0.00%> (ø)
include/modules/meta/static_module.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652652f...28fbc0f. Read the comment docs.

@patrick96 patrick96 merged commit 973b1fa into polybar:master Apr 4, 2022
@patrick96 patrick96 deleted the text-format branch April 4, 2022 10:01
@patrick96 patrick96 mentioned this pull request Nov 5, 2023
Merged
24 tasks
@gh0stzk gh0stzk mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Angle brackets escaped in text module Make text module a label
1 participant
@patrick96