fix(script): clear output when exec-if fails #2675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## hotfix/3.6.3 #2675 +/- ##
================================================
- Coverage 13.77% 13.77% -0.01%
================================================
Files 153 153
Lines 11282 11284 +2
================================================
Hits 1554 1554
- Misses 9728 9730 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
patrick96
requested changes
Apr 4, 2022
src/adapters/script_runner.cpp
Outdated
| @@ -47,6 +47,7 @@ script_runner::interval script_runner::process() { | |||
|
|
|||
| void script_runner::clear_output() { | |||
| set_output(""); | |||
| m_on_update(m_data); | |||
There was a problem hiding this comment.
We should only update if set_output return true.
54873e0 to
b489d5e
Compare
|
Oh, I saw that you tried to retarget the PR at the same time ^^ |
5b70ce4 to
f656b3c
Compare
patrick96
approved these changes
Apr 4, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixes the issue when output is not cleared after
exec-iffailed.Related Issues & Documents
Closes #2674
Documentation (check all applicable)