feat(pulseaudio): define reverse-scroll option #2664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
requested changes
Mar 24, 2022
There was a problem hiding this comment.
Nice. I didn't know that that's how natural scrolling was implemented, but that actually makes a lot of sense.
Please also add your changes to the changelog: https://github.com/polybar/polybar/blob/master/CONTRIBUTING.md#changelog
src/modules/pulseaudio.cpp
Outdated
| @@ -26,6 +26,7 @@ namespace modules { | |||
|
|
|||
| auto sink_name = m_conf.get(name(), "sink", ""s); | |||
| bool m_max_volume = m_conf.get(name(), "use-ui-max", true); | |||
| m_invert_scroll = m_conf.get(name(), "invert-scroll", false); | |||
There was a problem hiding this comment.
Please call the option reverse-scroll to be consistent with other modules that also have such an option.
|
@patrick96, I have renamed the field and added changelog entry. |
patrick96
approved these changes
Apr 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
- Coverage 11.76% 11.76% -0.01%
==========================================
Files 149 149
Lines 11302 11306 +4
==========================================
Hits 1330 1330
- Misses 9972 9976 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
When we enable natural scrolling option in libinput, it sends scroll down event when we swipe up on the touchpad. This makes the pulseaudio module feel weird. This option fixes that.
druckdev
added a commit
to druckdev/polybar
that referenced
this pull request
Feb 16, 2024
reverse-scroll was already added as an option to pulseaudio in a2c1392 ("feat(pulseaudio): define reverse-scroll option (polybar#2664)"): > When we enable natural scrolling option in libinput, > it sends scroll down event when we swipe up on the touchpad. > This makes the pulseaudio module feel weird. > This option fixes that.
druckdev
added a commit
to druckdev/polybar
that referenced
this pull request
Feb 16, 2024
reverse-scroll was already added as an option to pulseaudio in a2c1392 ("feat(pulseaudio): define reverse-scroll option (polybar#2664)"): > When we enable natural scrolling option in libinput, > it sends scroll down event when we swipe up on the touchpad. > This makes the pulseaudio module feel weird. > This option fixes that. (cherry picked from commit c759b36)
9 tasks
druckdev
added a commit
to druckdev/polybar
that referenced
this pull request
Feb 16, 2024
reverse-scroll was already added as an option to pulseaudio in a2c1392 ("feat(pulseaudio): define reverse-scroll option (polybar#2664)"): > When we enable natural scrolling option in libinput, > it sends scroll down event when we swipe up on the touchpad. > This makes the pulseaudio module feel weird. > This option fixes that.
druckdev
added a commit
to druckdev/polybar
that referenced
this pull request
Nov 1, 2024
reverse-scroll was already added as an option to pulseaudio in a2c1392 ("feat(pulseaudio): define reverse-scroll option (polybar#2664)"): > When we enable natural scrolling option in libinput, > it sends scroll down event when we swipe up on the touchpad. > This makes the pulseaudio module feel weird. > This option fixes that. (cherry picked from commit c759b36)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When we enable natural scrolling option in libinput, it sends scroll down even when we swipe up on the touchpad.
This makes the pulseaudio module feel weird.
This option fixes that.
Related Issues & Documents
Documentation (check all applicable)
Add the following to the wiki under Pulseaudio: