Skip to content

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Since polybar sets WM_NORMAL_HINTS, awesomeWM for some reason no longer
respect the position set by polybar before mapping.

reconfiguring the window position once again after mapping the window,
again positions it correctly.

Related Issues & Documents

Reported on reddit: https://www.reddit.com/r/Polybar/comments/terkd8/polybar_misplacement_in_awesome_wm/

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 added this to the 3.6.2 milestone Mar 15, 2022
@patrick96 patrick96 force-pushed the fix/awesomewm-position branch 4 times, most recently from 42a0b11 to dd49f5a Compare March 15, 2022 21:03
Since polybar sets WM_NORMAL_HINTS, awesomeWM for some reason no longer
respect the position set by polybar before mapping.

reconfiguring the window position once again after mapping the window,
again positions it correctly.
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #2651 (42a0b11) into hotfix/3.6.2 (4556a4a) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 42a0b11 differs from pull request most recent head dd49f5a. Consider uploading reports for the commit dd49f5a to get more accurate results

@@               Coverage Diff                @@
##           hotfix/3.6.2    #2651      +/-   ##
================================================
- Coverage         13.79%   13.78%   -0.01%     
================================================
  Files               153      153              
  Lines             11266    11270       +4     
================================================
  Hits               1554     1554              
- Misses             9712     9716       +4     
Flag Coverage Δ
unittests 13.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/bar.cpp 0.00% <0.00%> (ø)
src/x11/icccm.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4556a4a...dd49f5a. Read the comment docs.

@patrick96 patrick96 merged commit 8173eaf into polybar:hotfix/3.6.2 Mar 15, 2022
@patrick96 patrick96 deleted the fix/awesomewm-position branch March 15, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant