Skip to content

fix: Allow negative values for tray and bar offset #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

fix: Allow negative values for tray and bar offset #2620

merged 1 commit into from
Mar 3, 2022

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Regression from #2578 where tray-offset-x, tray-offset-y, offset-x, and offset-y mistakenly where capped below at 0

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 force-pushed the fix/offset-negative branch 2 times, most recently from e0cb41a to 686a48e Compare March 3, 2022 21:23
@patrick96 patrick96 added this to the 3.6.1 milestone Mar 3, 2022
@codecov
Copy link

codecov bot commented Mar 3, 2022 •
edited
Loading

Codecov Report

Merging #2620 (0d8c09b) into hotfix/3.6.1 (a82e432) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

Impacted file tree graph

@@               Coverage Diff                @@
##           hotfix/3.6.1    #2620      +/-   ##
================================================
- Coverage         11.92%   11.92%   -0.01%     
================================================
  Files               153      153              
  Lines             11301    11305       +4     
================================================
  Hits               1348     1348              
- Misses             9953     9957       +4
Flag Coverage Δ
unittests 11.92% <14.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/bar.cpp 0.00% <0.00%> (ø)
src/utils/units.cpp 96.72% <50.00%> (-3.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a82e432...0d8c09b. Read the comment docs.

@patrick96 patrick96 force-pushed the fix/offset-negative branch 2 times, most recently from ef0fc22 to 0d8c09b Compare March 3, 2022 21:26
@patrick96 patrick96 merged commit 0b24080 into polybar:hotfix/3.6.1 Mar 3, 2022
@patrick96 patrick96 deleted the fix/offset-negative branch March 3, 2022 21:44
@patrick96 patrick96 mentioned this pull request Mar 5, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.
1 participant
@patrick96