Skip manpage and html doc installation if they weren't generated #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
requested changes
Mar 2, 2022
There was a problem hiding this comment.
Good catch :)
I want to get this into the 3.6.1 release and have changed the target for branch for that.
Since you didn't turn on write access to this branch for maintainers, could you manually cherry-pick your commit onto the hotfix/3.6.1 branch and also add an entry in the CHANGELOG.md?
Otherwise we get errors like this: CMake Error at doc/cmake_install.cmake:46 (file): file INSTALL cannot find "/<<PKGBUILDDIR>>/build/doc/html": No such file or directory. Call Stack (most recent call first): cmake_install.cmake:59 (include)
2989012 to
5f9b998
Compare
|
@patrick96 I couldn't find the option to give you permission to modify the fork. I have force-pushed to my branch based on hotfix/3.6.1, including the changelog changes. Thanks, |
patrick96
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Skip manpage and html doc installation if they weren't generated
Otherwise we get errors like this:
CMake Error at doc/cmake_install.cmake:46 (file):
file INSTALL cannot find
"/<>/build/doc/html": No such file or
directory.
Call Stack (most recent call first):
cmake_install.cmake:59 (include)
I noticed this issue when packaging the latest release on Debian (I should consider building and shipping the html docs BTW).
Related Issues & Documents
No issue reported AFAIK.
Documentation (check all applicable)