Skip to content

Conversation

foxyseta
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

The alsa module now supports middle and right button events (just like the pulseaudio module).

Related Issues & Documents

Closes #2566

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #2573 (2615480) into master (968d9c7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2573      +/-   ##
==========================================
- Coverage   10.83%   10.82%   -0.01%     
==========================================
  Files         149      149              
  Lines       10779    10785       +6     
==========================================
  Hits         1168     1168              
- Misses       9611     9617       +6     
Flag Coverage Δ
unittests 10.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/alsa.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 968d9c7...2615480. Read the comment docs.

@foxyseta
Copy link
Contributor Author

No problem! Sorry about that missing #😅

@patrick96 patrick96 merged commit d995a39 into polybar:master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middle and right mouse button events in alsa module
2 participants