feat(script): Environment field in custom/script #2512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns a list of key-value pairs starting with a prefix.
If you have in config:
```
env-FOO = bar
env-CAT = dog
```
then `get_with_prefix("env-")` will return
`[{"FOO", "bar"}, {"CAT", "dog"}]`
|
@patrick96 I have a question. How do I test a new config option? |
|
Do you mean adding unit tests for it? There isn't really any infrastructure for that unfortunately. I think it's fine doing this without tests for now. At some point we should write some code that allows us to easily construct config instances with certain given values. |
Codecov Report
@@ Coverage Diff @@
## master #2512 +/- ##
==========================================
+ Coverage 10.10% 10.22% +0.12%
==========================================
Files 147 145 -2
Lines 10235 10110 -125
==========================================
Hits 1034 1034
+ Misses 9201 9076 -125
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Before passing the cmd to exec() we set the required environment variables. Also add the test for it.
This stores the key-value pairs specified for the script module. The command to be executed must pass on this argument.
patrick96
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR wil add the
env-*config option in the script moduleRelated Issues & Documents
Fixes #2090.
Documentation (check all applicable)
Document the
env-*option for the 'script' module in the wiki.