Skip to content

Release 3.5.7 #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 21, 2021
Merged

Release 3.5.7 #2506

merged 3 commits into from
Sep 21, 2021

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Release

Description

See CHANGELOG.md

Related Issues & Documents

Fixes #2479
Fixes #2442
Fixes #2500

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96
tray: Properly handle missing _XEMBED_INFO
6136c08 
The icon not supporting XEMBED is not fatal, we just treat is as always
mapped.

Fixes #2479
Fixes #2442
@patrick96
fix(ipc): Replace all %pid% tokens
a8cba9c 
Fixes #2500
@patrick96
Release 3.5.7
92722e0
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #2506 (92722e0) into master (eb9c192) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2506      +/-   ##
=========================================
- Coverage    7.21%   7.21%   -0.01%     
=========================================
  Files         156     156              
  Lines       10727   10733       +6     
=========================================
  Hits          774     774              
- Misses       9953    9959       +6
Flag Coverage Δ
unittests 7.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/ipc.cpp 0.00% <0.00%> (ø)
src/x11/tray_client.cpp 0.00% <0.00%> (ø)
src/x11/tray_manager.cpp 0.00% <0.00%> (ø)
src/x11/xembed.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9c192...92722e0. Read the comment docs.

@patrick96 patrick96 merged commit 2512123 into master Sep 21, 2021
@patrick96 patrick96 deleted the hotfix/3.5.7 branch September 21, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom/ipc: Only first appearance of %pid% is replaced. Fcitx tray icon not showing in tray bar GoldenDict tray icon is misplaced in v3.5.6
1 participant
@patrick96