Skip to content

Add missing relational operators to VarIterator #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add missing relational operators to VarIterator #2883

wants to merge 1 commit into from

Conversation

vfjpl
Copy link
Contributor

@vfjpl vfjpl commented Jan 14, 2020

Was not sure if implementation should be put in .cpp or in .h with inline. So I did the same thing as the two operators that was already there.

@vfjpl
Copy link
Contributor Author

vfjpl commented Jul 13, 2020

Any feedback?

@obiltschnig obiltschnig requested a review from aleks-f July 17, 2020 11:33
aleks-f
aleks-f reviewed Jul 17, 2020
View reviewed changes
Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfjpl please add tests and redirect pull to devel branch

@vfjpl vfjpl closed this Aug 14, 2020
@vfjpl vfjpl mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-f aleks-f aleks-f left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfjpl @aleks-f