Reorganise external libs to separate subdirectory #4996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8caa21 to
3413c1c
Compare
e9586e6 to
9bb3cdf
Compare
…libraries (using OBJECT library type and link using BUILD_LOCAL_INTERFACE)
b1c4e4d to
94538ea
Compare
94538ea to
c34d433
Compare
1f69e89 to
2294324
Compare
…em only when necessary.
…e and make usage of hpdf only internal.
88dfe8f to
3dcc0b7
Compare
bdea5f3 to
15ab4cb
Compare
8ee234c to
a14ac2e
Compare
a14ac2e to
f741f2c
Compare
…on, no need to link again to Poco::Zip
febe8f5 to
6b25b03
Compare
…n linking, disable it
… by making it atomic.
74f9fc0 to
7180ea8
Compare
|
| if (POCO_UNBUNDLED) | ||
| target_link_libraries(_BUNDLED_HPDF PRIVATE PNG::PNG) | ||
| else() | ||
| target_link_libraries(_BUNDLED_HPDF PRIVATE "$<BUILD_LOCAL_INTERFACE:PNG::PNG>") |
There was a problem hiding this comment.
Is there an alternate solution to the BUILD_LOCAL_INTERFACE generator expression here? I think it would be good if Poco kept the cmake minimum to 3.15, or at least not jumping all the way to 3.26.
There was a problem hiding this comment.
I was not able to find other solution that does not involve writing own custom CMake scripts. And CMake 3.26 is the first version that has clean solution to link private Poco library and not get undefined export errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4358.
Source code of external libraries is moved to subdirectory
dependencieswhere each of the libraries has its own subdirectory.When creating a bundled build, a static library is created and then linked where appropriate. For unbundled builds system provided library is linked.
This mechanism allows cleaner separation of Poco and other code, easier upgrade and the possibility to have fine-grained bundled options per external library.