-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Description
Expected behavior
ThreadPool's destructor should exist right away when there are no runnables anymore
Actual behavior
ThreadPool is in a self imposed 10-second holding pattern waiting for stuff that is already gone
The joinAll is immediatly satisfied, but the ThreadPool destructor doesn't let go until 10 seconds later.
Steps to reproduce the problem
#include "pch.h" // nothing in here
#include <iostream>
#include <chrono>
#include <thread>
#include "Poco/Runnable.h"
#include "Poco/Thread.h"
#include "Poco/ThreadPool.h"
using namespace std;
class Worker : public Poco::Runnable
{
static bool _shutDown;
public:
Worker()
{
}
void run()
{
thread::id this_id = this_thread::get_id();
cout << "Start. [Worker: tid:" << this_id << "]" << endl;
while (!_shutDown)
{
std::this_thread::sleep_for(std::chrono::milliseconds(250));
cout << "Working. [Worker: tid:" << this_id << "]" << endl;
}
cout << "Leaving. [Worker: tid:" << this_id << "]" << endl;
}
static void Initialize() {
_shutDown = false;
}
static void Shutdown() {
_shutDown = true;
}
};
bool Worker::_shutDown = false;
int main()
{
Worker::Initialize();
cout << "Hello World!\n";
Worker worker1; // create worker threads
Worker worker2;
Worker::Shutdown(); // workers will come up, and then immediatly be told to go away
Poco::ThreadPool::defaultPool().start(worker1);
Poco::ThreadPool::defaultPool().start(worker2);
Poco::ThreadPool::defaultPool().joinAll();
system("pause");
}
H:\github\ghstahl\poco.windows.visualstudio\src\x64\Debug>PocoThreadPoolPlay.exe
Hello World!
Start. [Worker: tid:56164]Start. [Worker: tid:68904]
Leaving. [Worker: tid:56164]
Leaving. [Worker: tid:68904]
Press any key to continue . . . < I press any key>
<waits here for 10 seconds when there is no reason to>
POCO version
Latest
Compiler and version
Microsoft Visual Studio Enterprise 2017
Version 15.8.2
VisualStudio.15.Release/15.8.2+28010.2016
Microsoft .NET Framework
Version 4.7.03056
Installed Version: Enterprise
Visual C++ 2017 00369-90250-05476-AA291
Microsoft Visual C++ 2017
ADL Tools Service Provider 1.0
This package contains services used by Data Lake tools
Application Insights Tools for Visual Studio Package 8.13.10627.1
Application Insights Tools for Visual Studio
ASP.NET and Web Tools 2017 15.8.05077.0
ASP.NET and Web Tools 2017
ASP.NET Core Razor Language Services 15.8.31590
Provides languages services for ASP.NET Core Razor.
ASP.NET Web Frameworks and Tools 2017 5.2.60618.0
For additional information, visit https://www.asp.net/
Azure App Service Tools v3.0.0 15.8.05023.0
Azure App Service Tools v3.0.0
Azure Data Lake Node 1.0
This package contains the Data Lake integration nodes for Server Explorer.
Azure Data Lake Tools for Visual Studio 2.3.4000.4
Microsoft Azure Data Lake Tools for Visual Studio
Azure Functions and Web Jobs Tools 15.8.05023.0
Azure Functions and Web Jobs Tools
Azure Stream Analytics Tools for Visual Studio 2.3.4000.4
Microsoft Azure Stream Analytics Tools for Visual Studio
C# Tools 2.9.0-beta8-63208-01
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Common Azure Tools 1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.
Cookiecutter 15.8.18201.1
Provides tools for finding, instantiating and customizing templates in cookiecutter format.
Fabric.DiagnosticEvents 1.0
Fabric Diagnostic Events
GitHub.VisualStudio 2.5.2.2500
A Visual Studio Extension that brings the GitHub Flow into Visual Studio.
JavaScript Language Service 2.0
JavaScript Language Service
JavaScript Project System 2.0
JavaScript Project System
JetBrains ReSharper Ultimate 2018.1 Build 112.0.20180414.70444
JetBrains ReSharper Ultimate package for Microsoft Visual Studio. For more information about ReSharper Ultimate, visit http://www.jetbrains.com/resharper. Copyright © 2018 JetBrains, Inc.
Microsoft Azure HDInsight Azure Node 2.3.4000.4
HDInsight Node under Azure Node
Microsoft Azure Hive Query Language Service 2.3.4000.4
Language service for Hive query
Microsoft Azure Service Fabric Tools for Visual Studio 2.3
Microsoft Azure Service Fabric Tools for Visual Studio
Microsoft Azure Stream Analytics Language Service 2.3.4000.4
Language service for Azure Stream Analytics
Microsoft Azure Stream Analytics Node 1.0
Azure Stream Analytics Node under Azure Node
Microsoft Azure Tools 2.9
Microsoft Azure Tools for Microsoft Visual Studio 2017 - v2.9.10730.2
Microsoft Continuous Delivery Tools for Visual Studio 0.4
Simplifying the configuration of continuous build integration and continuous build delivery from within the Visual Studio IDE.
Microsoft JVM Debugger 1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines
Microsoft Library Manager 1.0
Install client-side libraries easily to any web project
Microsoft MI-Based Debugger 1.0
Provides support for connecting Visual Studio to MI compatible debuggers
Microsoft Visual C++ Wizards 1.0
Microsoft Visual C++ Wizards
Microsoft Visual Studio Tools for Containers 1.1
Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.
Microsoft Visual Studio VC Package 1.0
Microsoft Visual Studio VC Package
MLGen Package Extension 1.0
MLGen Package Visual Studio Extension Detailed Info
NuGet Package Manager 4.6.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit http://docs.nuget.org/.
ProjectServicesPackage Extension 1.0
ProjectServicesPackage Visual Studio Extension Detailed Info
Python 15.8.18201.1
Provides IntelliSense, projects, templates, debugging, interactive windows, and other support for Python developers.
Python - Django support 15.8.18201.1
Provides templates and integration for the Django web framework.
Python - IronPython support 15.8.18201.1
Provides templates and integration for IronPython-based projects.
Python - Profiling support 15.8.18201.1
Profiling support for Python projects.
R Tools for Visual Studio 1.3.40517.1016
Provides project system, R Interactive window, plotting, and more for the R programming language.
ResourcePackage Extension 1.0
ResourcePackage Visual Studio Extension Detailed Info
ResourcePackage Extension 1.0
ResourcePackage Visual Studio Extension Detailed Info
Snapshot Debugging Extension 1.0
Snapshot Debugging Visual Studio Extension Detailed Info
SQL Server Data Tools 15.1.61808.07020
Microsoft SQL Server Data Tools
Syntax Visualizer 1.0
An extension for visualizing Roslyn SyntaxTrees.
Test Adapter for Boost.Test 1.0
Enables Visual Studio's testing tools with unit tests written for Boost.Test. The use terms and Third Party Notices are available in the extension installation directory.
Test Adapter for Google Test 1.0
Enables Visual Studio's testing tools with unit tests written for Google Test. The use terms and Third Party Notices are available in the extension installation directory.
ToolWindowHostedEditor 1.0
Hosting json editor into a tool window
TypeScript Tools 15.8.20801.2001
TypeScript Tools for Microsoft Visual Studio
Visual Basic Tools 2.9.0-beta8-63208-01
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.
Visual C++ for Linux Development 1.0.9.27924
Visual C++ for Linux Development
Visual F# Tools 10.2 for F# 4.5 15.8.0.0. Commit Hash: c55dd2c3d618eb93a8d16e503947342b1fa93556.
Microsoft Visual F# Tools 10.2 for F# 4.5
Visual Studio Code Debug Adapter Host Package 1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio
Visual Studio Tools for CMake 1.0
Visual Studio Tools for CMake
Visual Studio Tools for Containers 1.0
Visual Studio Tools for Containers
Visual Studio Tools for Universal Windows Apps 15.0.28010.00
The Visual Studio Tools for Universal Windows apps allow you to build a single universal app experience that can reach every device running Windows 10: phone, tablet, PC, and more. It includes the Microsoft Windows 10 Software Development Kit.
Operating system and version
Windows 10
Other relevant information
x64