Skip to content

Double cache retrieval in README #130

@falko-apheris

Description

@falko-apheris

In the readme I see under "Use cache to reduce installation time"

- name: Install Node.js
        uses: actions/setup-node@v4
        with:
          node-version: 20
          cache: 'pnpm'

Which is caching pnpm install artifacts and restoring them again. But just below there is

- uses: actions/cache@v4
        name: Setup pnpm cache
        with:
          path: ${{ env.STORE_PATH }}
          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
          restore-keys: |
            ${{ runner.os }}-pnpm-store-

This seems like a duplication. I obsevered that the output of the ci pipleline indicates that both actions are writing to the same directory

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions