-
Notifications
You must be signed in to change notification settings - Fork 249
Attempted update to 0.7/1.0 - May need more work given segfault #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh, and I moved to the new package manager, which required assigning a uuid. I wasn't sure if that's the appropriate thing to do for a registered package, so that might need rolling back. |
@ianshmean Thanks very much for the efforts!! I will try to see what is seg-faulting. Meanwhile, there seem to be a pre-generated UUID for every existing old package. For example, the one for Mocha.jl is here. The UUID seem to be different to the one in your PR. How did you generate the UUID in your PR? Also, I'm new to the new Package management system, my guess is that the file |
Happy to help! I've updated the UUID to match, and as for the |
@pluskid I've been trying to figure out the segfault but failed so far. Have you found any clues? (I'm eager to incorporate Mocha into some v1.0 code) |
Still pushing through compatibility issues and modifying things on top of your commits. I'm trying to work it out from the unit tests, which I think is potentially easier to debug than the notebook. |
By the way, my MacOS Mojave setup was missing GraphViz for the Edit: Perhaps this is a factor for the specific IJulia example, rather than a package dependency.. could just be a comment at the top of that notebook i.e. |
The segfault is mysteriously caused by the logging library memento.jl. I have temporarily disabled it. The fixes for unit tests now should work on CPU, but there should still be a lot of work to be done on GPU. Hope I can fix those over the weekend. I created a new PR that contains your commits to track the progress #255 |
Great! Thanks, I know this is tedious. |
I think I've covered the basic updates to 1.0 syntax and this now now loads in 1.0.2 and 1.1.0-dev
However, the only example I've run (examples/ijulia/ilsvrc12/imagenet-classifier.ipynb) segfaults at the
net = Net("imagenet", backend, layers)
line.