Skip to content

Fix mergo configs #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Fix mergo configs #663

merged 1 commit into from
Aug 28, 2025

Conversation

michaeljguarino
Copy link
Member

I think the slice deep copy behavior has some goofy side-effects

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino
Fix mergo configs
22c84f1 
I think the slice deep copy behavior has some goofy side-effects
@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug hotfix labels Aug 28, 2025
@michaeljguarino michaeljguarino merged commit 184ff00 into main Aug 28, 2025
13 checks passed
@michaeljguarino michaeljguarino deleted the fix-slice-deep-copy branch August 28, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zreigz zreigz Awaiting requested review from zreigz zreigz is a code owner

@floreks floreks Awaiting requested review from floreks floreks is a code owner

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm maciaszczykm is a code owner

Assignees
No one assigned
Labels
bug-fix This pull request fixes a bug hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaeljguarino