feat: add plural cd services tarball command
#661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/command/cd/cd_services.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("could not parse console url: %w", err) | ||
| } | ||
| digestURL := fmt.Sprintf("%s://%s/ext/v1/digests?id=%s", parsedConsoleURL.Scheme, parsedConsoleURL.Host, service.ID) |
There was a problem hiding this comment.
don't fetch the digest first, it's superfluous since you're always downloading the tarball
There was a problem hiding this comment.
Oh, okay. At first I thought that it might be required argument. It's deleted now.
|
@michaeljguarino I have added a check if target directory is empty, but perhaps you would prefer different behavior here. Maybe we should display confirmation message if target dir is not empty? Or maybe introduce some flag or generate prefix? Edit: Updated default dir to |
733f030 to
f78b876
Compare
michaeljguarino
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Labels
Test Plan
Checklist