fix(dropdownfield): display of username

btry · btry · commit af43a9cf1dce · 2023-10-17T15:02:51.000+02:00
in Formcreator 2.4.2, user was displayed with first and last name
diff --git a/inc/field/dropdownfield.class.php b/inc/field/dropdownfield.class.php
@@ -357,11 +357,17 @@ public function getRenderedHtml($domain, $canEdit = true): string {
          $item = new $itemtype();
          $value = '';
          if ($item->getFromDB($this->value)) {
-            $column = 'name';
+            $value = $item->fields['name'];
             if ($item instanceof CommonTreeDropdown) {
-               $column = 'completename';
+               $value = $item->fields['completename'];
+            } else {
+               /** @var CommonDBTM $item */
+               switch ($item->getType()) {
+                  case User::class:
+                     $value = (new DbUtils())->getUserName($item->getID());
+                     break;
+               }
             }
-            $value = $item->fields[$column];
          }
 
          return $value;
diff --git a/tests/3-unit/PluginFormcreatorForm.php b/tests/3-unit/PluginFormcreatorForm.php
@@ -485,7 +485,7 @@ public function testCreateValidationNotification(User $requester, User $validato
 
       $form = $this->getForm([
          'name'                  => 'validation notification',
-         'validation_required'   => \PluginFormcreatorForm_Validator::VALIDATION_USER,
+         'validation_required'   => PluginFormcreatorForm_Validator::VALIDATION_USER,
          '_validator_users'      => [$validator->getID()],
       ]);
       $this->getSection([
