fix: duplicate key when updating a profile

btry · btry · commit 1bd6a2ab6517 · 2023-02-17T09:29:10.000+01:00
diff --git a/hook.php b/hook.php
@@ -732,11 +732,18 @@ function plugin_formcreator_hook_update_profile(CommonDBTM $item) {
    }
    $dashboardRight = new DashboardRight();
    if ($item->fields['interface'] == 'helpdesk') {
-      $dashboardRight->add([
+      $dashboardRight->getFromDBByCrit([
          'dashboards_dashboards_id' => $dashboard->fields['id'],
          'itemtype' => Profile::getType(),
          'items_id' => $item->getID(),
       ]);
+      if ($dashboardRight->isNewItem()) {
+         $dashboardRight->add([
+            'dashboards_dashboards_id' => $dashboard->fields['id'],
+            'itemtype' => Profile::getType(),
+            'items_id' => $item->getID(),
+         ]);
+      }
    } else {
       $dashboardRight->delete([
          'dashboards_dashboards_id' => $dashboard->fields['id'],
