fix(form): import access restrictions may ignore uuids

btry · btry · commit 9d23d4c1e9b4 · 2023-10-05T09:01:29.000+02:00
diff --git a/inc/form.class.php b/inc/form.class.php
@@ -1904,15 +1904,20 @@ public static function import(PluginFormcreatorLinker $linker, $input = [], $con
          $input[$key] = $DB->escape($input[$key]);
       }
 
+      // Do not process theses fields when adding / updating forms
+      // They will be imported later; see the variable $subItems below
+      $input2 = $input;
+      unset($input2['users'], $input2['groups'], $input2['profiles']);
+
       // Add or update the form
       $originalId = $input[$idKey];
       $item->skipChecks = true;
       if ($itemId !== false) {
-         $input['id'] = $itemId;
-         $item->update($input);
+         $input2['id'] = $itemId;
+         $item->update($input2);
       } else {
-         unset($input['id']);
-         $itemId = $item->add($input);
+         unset($input2['id']);
+         $itemId = $item->add($input2);
       }
       $item->skipChecks = false;
       if ($itemId === false) {
