fix(abstractitiltarget): copy may generate unwanted ouput to navigator

btry · btry · commit 8792ed3dc496 · 2022-10-27T16:31:20.000+02:00
diff --git a/inc/abstractitiltarget.class.php b/inc/abstractitiltarget.class.php
@@ -2331,7 +2331,7 @@ protected function prepareUploadedFiles(array $data): array {
       foreach (PluginFormcreatorCommon::getDocumentsFromTag($data['content']) as $document) {
          $prefix = uniqid('', true);
          $filename = $prefix . 'image_paste.' . pathinfo($document['filename'], PATHINFO_EXTENSION);
-         if (!copy(GLPI_DOC_DIR . '/' . $document['filepath'], GLPI_TMP_DIR . '/' . $filename)) {
+         if (!@copy(GLPI_DOC_DIR . '/' . $document['filepath'], GLPI_TMP_DIR . '/' . $filename)) {
             continue;
          }
 

Original file line number	Diff line number	Diff line change
`@@ -2331,7 +2331,7 @@ protected function prepareUploadedFiles(array $data): array {`
`2331`	`2331`	`foreach (PluginFormcreatorCommon::getDocumentsFromTag($data['content']) as $document) {`
`2332`	`2332`	`$prefix = uniqid('', true);`
`2333`	`2333`	`$filename = $prefix . 'image_paste.' . pathinfo($document['filename'], PATHINFO_EXTENSION);`
`2334`		`- if (!copy(GLPI_DOC_DIR . '/' . $document['filepath'], GLPI_TMP_DIR . '/' . $filename)) {`
	`2334`	`+ if (!@copy(GLPI_DOC_DIR . '/' . $document['filepath'], GLPI_TMP_DIR . '/' . $filename)) {`
`2335`	`2335`	`continue;`
`2336`	`2336`	`}`
`2337`	`2337`