fix(dropdownfield): empty SQL IN statement when restricted tickets rights

btry · btry · commit 5c5244a85542 · 2022-12-01T13:36:45.000+01:00
diff --git a/inc/field/dropdownfield.class.php b/inc/field/dropdownfield.class.php
@@ -240,14 +240,17 @@ public function buildParams($rand = null) {
                ];
             }
             if (Session::haveRight(Ticket::$rightname, Ticket::READGROUP)) {
-               $requestersObserversGroupsQuery = new QuerySubQuery([
+               $sub_query = [
                   'SELECT' => 'tickets_id',
                   'FROM' => Group_Ticket::getTable(),
                   'WHERE' => [
-                     'groups_id' => $_SESSION['glpigroups'],
                      'type' => [CommonITILActor::REQUESTER, CommonITILActor::OBSERVER]
                   ],
-               ]);
+               ];
+               if (count($_SESSION['glpigroups']) > '0') {
+                  $sub_query['WHERE']['groups_id'] = $_SESSION['glpigroups'];
+               }
+               $requestersObserversGroupsQuery = new QuerySubQuery($sub_query);
                if (!isset($dparams_cond_crit['OR']['id'])) {
                   $dparams_cond_crit['OR'] = [
                      'id' => $requestersObserversGroupsQuery,
