Implement pscale shell for Postgres
#1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--replica and --role work as expected. --local-addr is refused because psql connects directly, not through a local proxy. --remote-addr is supported but unlikely to be useful. We hard-code port :5432 instead of going through the connection pooler on :6432, because the pooler pools connections by logged-in role. We're using an ephemeral role, so we'd always get assigned to our own connection. We'd be paying the extra hop through the pooler for no benefit.
`startShellForPostgres` spawns `psql` synchronously and doesn't need background threads for a proxy and for password renewals, so we can dump all the concurrency complexity.
This puts the MySQL code path back almost exactly how it was before the Postgres changes. It's logically identical. Just doing smaller diffs for easier reviews.
nickvanw
approved these changes
Aug 12, 2025
piki
added a commit
that referenced
this pull request
Aug 12, 2025
`pscale shell` was listed as Vitess-specific, but it works with all databases now. This change should've been in #1103, but I forgot. `pscale mcp` was listed as a platform/account command, but it's really a database management command. So I'm moving that, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pscale shellworks for Postgres databases now. Unlike Vitess, for Postgres, we just usepsqlto connect directly to the database, with no local proxy required.--replicaconnects to a read-only replica.--roleallowsreader,writer,readwriter, andadminroles, the same as Vitess.We always connect to :5432, rather than the pooler on port :6432. We're creating an ephemeral account, and poolers have to give each different account its own connection, so we'd never get pooled. Why pay the extra hop for no benefit?