Skip to content

Add shellcheck to ci.installer.yml #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2025
Merged

Add shellcheck to ci.installer.yml #259

merged 1 commit into from
Jan 15, 2025

Conversation

abitrolly
Copy link
Contributor

No description provided.

@jhheider
Copy link
Contributor

Always prefer a good lint.

@abitrolly
Copy link
Contributor Author

The action doesn't seem to work. At least this error should be captured.

$ pkgx shellcheck tmp/installer.sh -S style
...
In tmp/installer.sh line 29:
      $SUDO apt-get $cmd -qq -o=Dpkg::Use-Pty=0 $@
                    ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
                                                ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.

@abitrolly abitrolly mentioned this pull request Jan 14, 2025
Merged
@abitrolly abitrolly mentioned this pull request Jan 15, 2025
Open
@mxcl mxcl force-pushed the main branch 20 times, most recently from 1111a2f to eb1c861 Compare January 15, 2025 16:38
@abitrolly
Copy link
Contributor Author

reviewdog only reports changed lines - reviewdog/action-shellcheck#72 - but necessary to check settings to ensure it reports warning info's etc.

@mxcl mxcl merged commit 76e1dc6 into pkgxdev:main Jan 15, 2025
22 checks passed
@abitrolly abitrolly deleted the patch-1 branch January 15, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abitrolly @jhheider @mxcl