fix: DOMContainer scaling if canvas width/height is percentage #11539
+209
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issues with incorrect DOMContainer positioning when the canvas is scaled. Introduces CanvasTransformSync to manage the DOM element's transform based on canvas size and position, utilizing ResizeObserver for efficient updates. Uses a fallback to the Ticker is ResizeObserver is not found (been supported since 2020) Ensures correct scaling and translation of DOM elements relative to the canvas, resolving discrepancies in rendering.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8b61857:
|
bigtimebuddy
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11537
Addresses issues with incorrect DOMContainer positioning when the canvas is scaled.
Introduces CanvasTransformSync to manage the DOM element's transform based on canvas size and position, utilizing
ResizeObserver for efficient updates. Uses a fallback to the Ticker is ResizeObserver is not found (been supported since 2020)
Ensures correct scaling and translation of DOM elements relative to the canvas, resolving discrepancies in rendering.