fix: lineHeight calculation for multi-line layout for BitmapText
#11531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure multi-line text spacing looks similar with `new PIXI.Text(...)` - Allow overriding the `lineHeight` from a custom font that installed using `BitmapFont.install(...)` - Fix final `BitmapText` height when using the `lineHeight` - If no `lineHeight` is specified when installing the `BitmapFont`, the default value will be `fontMetrics.fontSize`, which may affect the layout of any `BitmapText` that does not explicitly set a `lineHeight`.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 272dc68:
|
…l tests If no custom line height is specified when using BitmapText, I decided to use the font size from the font metrics when calculating the line height — and it seems it's fixed the characters that shifted downward on some tests.
|
pixi.js-base • pixi.js-bunny-mark commit: |
This was
linked to
issues
Aug 5, 2025
Zyie
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
new PIXI.Text(...)BitmapTextto override thelineHeightconfigured in a custom font that installed usingBitmapFont.install(...). This ensures thelineHeightconfigured by the user inBitmapTexttakes precedence, while the value originally set inBitmapFontwill be ignored.”BitmapTextheight when using thelineHeightPre-Merge Checklist
npm run lint)npm run test)Preview
Playground: https://www.pixiplayground.com/#/edit/V6gL8z_bGalT5yiW4Mqv2 (v8.11.0)
Before:
After:
Link
lineHeightto BitmapText to solve: