-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
fix: Installed bitmap text showing wrong fill #11523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes: #11440 Updates the logic used to determine when bitmap text styles can use tinting instead of baking colors. Includes a new visual test case to verify correct rendering of bitmap text with gradient fills and tinting.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b2b2d2e:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the weird artifact in the test image under the "t"?
That is a different bug that i am going to be looking into. This is caused when you define a We do have other tests with the same artifact e.g: https://github.com/pixijs/pixijs/blob/dev/tests/visual/snapshots/bitmap-install-layout-text-scene-ts-webgpu.png |
pixi.js-base • pixi.js-bunny-mark
commit: |
pixi.js-base • pixi.js-bunny-mark
commit: |
@bigtimebuddy I've added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Nit. any other, maybe shorter, names for "allowFillOverride"?
- dynamicFill
- fillable
- fillOverride
I think it's good to pick something that's more of a noun when declaring an option or describing state, rather than a verb.
Renames the `allowFillOverride` option to `dynamicFill` for clarity and consistency. This change provides a more descriptive name that better reflects the option's purpose, which is to control whether the fill color of a bitmap font can be dynamically changed via tinting.
Fixes: #11440
Updates the logic used to determine when bitmap text styles can use tinting instead of baking colors.
Includes a new visual test case to verify correct rendering of bitmap text with gradient fills and tinting.