Skip to content

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jul 8, 2025

Fixes: #11440

Updates the logic used to determine when bitmap text styles can use tinting instead of baking colors.

Includes a new visual test case to verify correct rendering of bitmap text with gradient fills and tinting.

Fixes: #11440

Updates the logic used to determine when bitmap text styles can use tinting instead of baking colors.

Includes a new visual test case to verify correct rendering of bitmap text with gradient fills and tinting.
Copy link

codesandbox-ci bot commented Jul 8, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2b2d2e:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the weird artifact in the test image under the "t"?

@Zyie
Copy link
Member Author

Zyie commented Jul 8, 2025

What is the weird artifact in the test image under the "t"?

That is a different bug that i am going to be looking into. This is caused when you define a fontSize that is different to the one that is installed with a stroke.

We do have other tests with the same artifact e.g: https://github.com/pixijs/pixijs/blob/dev/tests/visual/snapshots/bitmap-install-layout-text-scene-ts-webgpu.png

Copy link

pkg-pr-new bot commented Jul 28, 2025

pixi.js-basepixi.js-bunny-mark

npm i https://pkg.pr.new/pixijs/pixijs/pixi.js@11523

commit: 25ad5f2

Copy link

pkg-pr-new bot commented Jul 28, 2025

pixi.js-basepixi.js-bunny-mark

npm i https://pkg.pr.new/pixijs/pixijs/pixi.js@11523

commit: 4466677

@Zyie
Copy link
Member Author

Zyie commented Jul 28, 2025

@bigtimebuddy I've added a allowFillOverride option to the install options like we previously talked about. Let me know what you think!

@Zyie Zyie force-pushed the fix/bitmap-fill branch from 22e1442 to 7f342c0 Compare July 28, 2025 12:46
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Nit. any other, maybe shorter, names for "allowFillOverride"?

  • dynamicFill
  • fillable
  • fillOverride

I think it's good to pick something that's more of a noun when declaring an option or describing state, rather than a verb.

Renames the `allowFillOverride` option to `dynamicFill` for clarity and consistency.

This change provides a more descriptive name that better reflects the option's purpose, which is to control whether the fill color of a bitmap font can be dynamically changed via tinting.
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jul 29, 2025
@Zyie Zyie added this pull request to the merge queue Jul 29, 2025
Merged via the queue into dev with commit 995ac2c Jul 29, 2025
7 checks passed
@Zyie Zyie deleted the fix/bitmap-fill branch July 29, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: BitmapFontManager.install miss override the fill value if any fill in TextStyle
3 participants