fix: HTML text rendering with broken tags #11521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures HTML text renders correctly even with incomplete or malformed tags. The text is now parsed by the DOM before being injected into the SVG, which allows the browser to correct minor HTML errors. Also sanitizes text to replace common HTML entities with their XML-compatible equivalents. Adds a visual test to verify the fix.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b6863c:
|
bigtimebuddy
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10638
Ensures HTML text renders correctly even with incomplete or malformed tags.
We now sanitizes text to replace common HTML tags (like in v7) plus we also check for incomplete tags and remove them if needed.
Adds a visual test to verify the fix.