Skip to content

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Jul 7, 2025

This PR addresses an issue where HTMLText was not correctly applying font weights specified in tag styles.

Key changes:

  • Ensures that all fonts weights are generated by getFontCss
  • Ensures that we use the font face data for CSS generation.
  • Updates font caching to support multiple font faces per URL.
  • Updates font unloading to correctly remove fonts from the cache and FontFaceSet.

- Ensures that all fonts weights are generated by `getFontCss`
- Ensures that we use the font face data for CSS generation.
- Updates font caching to support multiple font faces per URL.
- Updates font unloading to correctly remove fonts from the cache and FontFaceSet.
@Zyie Zyie linked an issue Jul 7, 2025 that may be closed by this pull request
Copy link

codesandbox-ci bot commented Jul 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9cfe856:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@Zyie Zyie changed the title fix: HTMLText correctly handles font weights fix: HTMLText incorrectly handling font weights Jul 8, 2025
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jul 16, 2025
@Zyie Zyie added this pull request to the merge queue Jul 17, 2025
Merged via the queue into dev with commit 9cbe9ec Jul 17, 2025
6 checks passed
@Zyie Zyie deleted the fix/html-text branch July 17, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: HTMLText Doesn't Correctly Handle Weights
2 participants