fix: warn if transparent background is set after opaque init #11514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6af681c:
|
Zyie
reviewed
Jul 3, 2025
Co-authored-by: Zyie <24736175+Zyie@users.noreply.github.com>
bigtimebuddy
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #10162
This PR adds a developer-facing warning when a transparent background color (like
'rgba(255, 0, 0, 0.5)') is set after the canvas has been initialized withbackgroundAlpha: 1(i.e., opaque).Browsers do not allow changing the canvas alpha setting after initialization. This silent behavior has confused many developers.
✅ This PR includes:
warn()message wrapped in#if _DEBUGso it’s dev-onlybackgroundAlphaexplaining that the alpha must be set at initialization timeThis was previously merged into my fork by mistake — resubmitting here for the official PixiJS
devbranch.Pre-Merge Checklist
backgroundAlpha)npm run lint)npm run test)