Skip to content

feat: support scaleMode for cacheAsTexture options #11578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 5, 2025
Merged

feat: support scaleMode for cacheAsTexture options #11578

merged 6 commits into from
Aug 5, 2025

Conversation

mayakwd
Copy link
Collaborator

@mayakwd mayakwd commented Jul 24, 2025

Fixes: #11575

Description of change

This feature adds the possibility to specify scaleMode for containers rendered in cacheAsTexture mode.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jul 24, 2025 •
edited
Loading

pixi.js-base • pixi.js-bunny-mark

npm i https://pkg.pr.new/pixijs/pixijs/pixi.js@11578

commit: db98a10

bigtimebuddy
bigtimebuddy approved these changes Jul 24, 2025
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thank you!

@mayakwd
Copy link
Collaborator Author

mayakwd commented Jul 24, 2025

Nice one. Thank you!

Always a pleasure. More to come 😅

GoodBoyDigital
GoodBoyDigital previously requested changes Jul 24, 2025
View reviewed changes
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!! Left a minor tweak request!

@mayakwd
Copy link
Collaborator Author

mayakwd commented Jul 24, 2025

@Zyie, I see that fork also triggers the build action "upload build to Stackblitz".
Is it possible to limit such pipelines to the original repository? For example, it's possible to limit by adding an if condition to yaml:

if: github.repository == ‘pixijs/pixijs’

Zyie
Zyie reviewed Jul 25, 2025
View reviewed changes
@Zyie
Copy link
Member

Zyie commented Jul 25, 2025 •
edited
Loading

Is it possible to limit such pipelines to the original repository?

Hey @mayakwd

I'm not a github workflow expert but as long as we still get the pull request bot for all PRs and it publishes all pushes for the main repo then feel free to make a PR for this!

@Zyie Zyie requested a review from GoodBoyDigital July 25, 2025 15:21
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Aug 5, 2025
@Zyie Zyie dismissed GoodBoyDigital’s stale review August 5, 2025 08:39

Reviewed again by Zyie after changes made

@Zyie Zyie added this pull request to the merge queue Aug 5, 2025
Merged via the queue into pixijs:dev with commit aca7f1a Aug 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

@GoodBoyDigital GoodBoyDigital Awaiting requested review from GoodBoyDigital

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Easy method of setting the scale mode of a cached texture
4 participants
@mayakwd @Zyie @bigtimebuddy @GoodBoyDigital