fix: Container.parent type not being nullable and possibly undefined #11567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Update Container.parent type from Container to Container | null to match the actual runtime behavior where parent can be null when a container is not attached to a parent.
Why necessary: The current type forces developers to use non-null assertions (!) or disable ESLint warnings when checking if a container has a parent, even though the runtime value can legitimately be null.
Example:
This change aligns the TypeScript types with the actual runtime behavior where parent is initialized as null and can be null when containers are detached from their parent.
Pre-Merge Checklist
npm run lint
)npm run test
) (the current dev branch seems to have many failing tests, I dont think its related)