Skip to content

fix: ObservablePoint toString #11430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix: ObservablePoint toString #11430

merged 1 commit into from
May 22, 2025

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented May 20, 2025

Summary

  • add Jest spec checking ObservablePoint.toString() outputs current coordinates

Testing

  • npm test (fails: run-s not found)

github-actions[bot]
github-actions bot reviewed May 20, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@Zyie Zyie changed the title Add ObservablePoint toString test fix: ObservablePoint toString May 20, 2025
@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 28bdc48:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 22, 2025
@Zyie Zyie added this pull request to the merge queue May 22, 2025
Merged via the queue into dev with commit b11ace4 May 22, 2025
5 of 6 checks passed
@Zyie Zyie deleted the codex/find-and-fix-a-critical-bug branch May 22, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

Assignees
No one assigned
Labels
codex ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zyie @bigtimebuddy