Skip to content

fix: letter spacing support getter #11429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 2, 2025
Merged

fix: letter spacing support getter #11429

merged 2 commits into from
Jun 2, 2025

Conversation

GoodBoyDigital
Copy link
Member

Summary

  • fix conditional logic in experimentalLetterSpacingSupported
  • ensure result cached to _experimentalLetterSpacingSupported
  • add test verifying getter returns boolean on first call

Testing

  • npm run test:unit (fails: EHOSTUNREACH when trying to download jest)

github-actions[bot]
github-actions bot reviewed May 20, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update Text docs
fix: text not rendering
feat: add new feature to Text
breaking: remove Text#resolution

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 20, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a76304b:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie changed the title Fix letter spacing support getter fix: letter spacing support getter May 20, 2025
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jun 2, 2025
@Zyie Zyie added this pull request to the merge queue Jun 2, 2025
Merged via the queue into dev with commit a61ea08 Jun 2, 2025
5 checks passed
@Zyie Zyie deleted the codex/fix-experimentalletterspacingsupported-getter branch June 2, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
codex ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoodBoyDigital @Zyie