fix: Fix type error on DOMContainer in strict codebases #11479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In codebases that load Pixi type definitions with
strictNullChecks
but withoutskipLibCheck
the change from #11346 causes the following error:From reading the code I assume the
null
means the_gpuData
is simply not used. As such I replaced it withnever
, which does satisfy TypeScript.cc @GoodBoyDigital
Pre-Merge Checklist
npm run lint
)npm run test
)