Skip to content

Conversation

Mysak0CZ
Copy link
Contributor

Description of change

In codebases that load Pixi type definitions with strictNullChecks but without skipLibCheck the change from #11346 causes the following error:

TS2344: Type 'null' does not satisfy the constraint 'GPUData'.
    81 |  * @standard
    82 |  */
  > 83 | export declare class DOMContainer extends ViewContainer<null> {
       |                                                         ^^^^
    84 |     /** @internal */
    85 |     readonly renderPipeId: string;
    86 |     /** @internal */

From reading the code I assume the null means the _gpuData is simply not used. As such I replaced it with never, which does satisfy TypeScript.

cc @GoodBoyDigital

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Copy link

codesandbox-ci bot commented Jun 12, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e42054a:

Sandbox Source
pixi.js-sandbox Configuration

@bigtimebuddy bigtimebuddy requested a review from Zyie June 12, 2025 14:55
@Zyie Zyie added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Jun 23, 2025
@Zyie Zyie added this pull request to the merge queue Jun 24, 2025
Merged via the queue into pixijs:dev with commit 84fc295 Jun 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants