fix: render layer detachment when destroying. #11384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where destroying a container did not remove its children from their render layers. The changes include detaching a child from its render layer in the helper mixin before emitting the removal event and adding tests for verifying both the container and render layer behavior upon destruction.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scene/container/container-mixins/childrenHelperMixin.ts | Added a conditional render layer detachment call before re-emitting the 'childRemoved' event. |
| src/scene/container/tests/Container.test.ts | Added tests to confirm that children are detached from their render layers and destroyed appropriately. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5a1951b:
|
bigtimebuddy
approved these changes
Apr 22, 2025
Co-authored-by: Matt Karl <matt@mattkarl.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fix issue where when destroying a container - the children were not being removed from the render layers.
Added test too.
fixes #11373
Pre-Merge Checklist
npm run lint)npm run test)