fix: state culling was flipped when rendering to a texture #11356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f88b869:
|
Zyie
approved these changes
Mar 27, 2025
bigtimebuddy
approved these changes
Mar 27, 2025
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR fixes an issue where face culling appears inverted when rendering to a render texture compared to rendering directly to the screen. This issue affects both render textures and filters (which use render textures internally).
The problem occurs because WebGL uses a different coordinate system when rendering to a texture (Y is flipped), which causes the winding order of triangles to be reversed. Since face culling depends on winding order, this results in front faces being culled instead of back faces and vice versa.
Changes
Added _invertFrontFace flag to track when rendering is happening to a texture
Implemented tracking mechanism for front face orientation in the GL state system
Added automatic front face culling correction when switching between screen and texture rendering
Ensured proper state restoration when context changes or when rendering finishes
Optimized GL state changes to only apply when actually needed
fixes #11350
Pre-Merge Checklist
npm run lint)npm run test)