fix: Inverse stencil mask should not modify stencil buffer during normal draws #11352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d805436:
|
4698425 to
ce0a370
Compare
|
Hello @GoodBoyDigital! Could I please ask you to review this tiny fix? Thank you in advance! |
GoodBoyDigital
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11301
Description of change
The current implementation of inverse masks works by incrementing stencil buffer where mask is, and then draws only on pixels that don't match the mask depth.
The
passOp, however, was set toreplace, which caused the stencil buffer to be set to the mask value in all areas where something was drawn.This effectively caused the effect that only first drawn thing was visible per-pixel.
This simple fix changes the
passOpto be"keep"- same as non-inverse variant, and updates the relevant test to test for this usecase.Pre-Merge Checklist
npm run lint)npm run test)